Skip to content

fix(async): set default concurrency to 10 tasks #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2024
Merged

fix(async): set default concurrency to 10 tasks #2256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86b72b0
fix(async): set default concurrency to 10 tasks
jhamman Sep 25, 2024
818fc73
fixup
jhamman Sep 25, 2024
39af2fc
Merge branch 'v3' into fix/default-concurrency
jhamman Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/zarr/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def reset(self) -> None:
{
"default_zarr_version": 3,
"array": {"order": "C"},
"async": {"concurrency": None, "timeout": None},
"async": {"concurrency": 10, "timeout": None},
"json_indent": 2,
"codec_pipeline": {
"path": "zarr.codecs.pipeline.BatchedCodecPipeline",
Expand Down
6 changes: 3 additions & 3 deletions tests/v3/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_config_defaults_set() -> None:
{
"default_zarr_version": 3,
"array": {"order": "C"},
"async": {"concurrency": None, "timeout": None},
"async": {"concurrency": 10, "timeout": None},
"json_indent": 2,
"codec_pipeline": {
"path": "zarr.codecs.pipeline.BatchedCodecPipeline",
Expand All @@ -62,15 +62,15 @@ def test_config_defaults_set() -> None:
}
]
assert config.get("array.order") == "C"
assert config.get("async.concurrency") is None
assert config.get("async.concurrency") == 10
assert config.get("async.timeout") is None
assert config.get("codec_pipeline.batch_size") == 1
assert config.get("json_indent") == 2


@pytest.mark.parametrize(
("key", "old_val", "new_val"),
[("array.order", "C", "F"), ("async.concurrency", None, 10), ("json_indent", 2, 0)],
[("array.order", "C", "F"), ("async.concurrency", 10, 20), ("json_indent", 2, 0)],
)
def test_config_defaults_can_be_overridden(key: str, old_val: Any, new_val: Any) -> None:
assert config.get(key) == old_val
Expand Down