Skip to content

fix(attrs): update array attrs in place #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2024
Merged

fix(attrs): update array attrs in place #2329

merged 3 commits into from
Oct 11, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Oct 10, 2024

Closes #2328

This now follows the same update logic used in the AsyncGroup class.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

jhamman
jhamman commented Oct 10, 2024
View reviewed changes
tests/v3/test_group.py
MemoryStore({}, mode="w"),
)
root.attrs["foo"] = "bar"
assert root.attrs["foo"] == "bar"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: things were working fine in the Group class but I added this test here just to be safe.

@jhamman jhamman merged commit bc938bd into zarr-developers:v3 Oct 11, 2024
20 checks passed
@jhamman jhamman added the V3 label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v3] failure to roundtrip attrs when set via dict interface
2 participants
@jhamman @d-v-b