Skip to content

Revert "V3 main sync w/ merge (#2335)" #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Oct 11, 2024

This reverts commit ce5f53e.

The above merge was supposed to be done without a squash. Reverting and will start again 🤦

@joshmoore
Copy link
Member

Sounds like that might be worth a force push, no?

@jhamman
Copy link
Member Author

jhamman commented Oct 11, 2024

I don't think that is needed. Really no harm in keeping the v3 history linear (with a revert commit).

@jhamman jhamman merged commit 124640a into v3 Oct 11, 2024
23 checks passed
@jhamman jhamman deleted the revert-2335-v3-main-sync-merge branch October 11, 2024 22:14
@jhamman jhamman mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants