-
-
Notifications
You must be signed in to change notification settings - Fork 331
Add default compressors to config #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
normanrz
merged 45 commits into
zarr-developers:main
from
scalableminds:default-compressor
Dec 19, 2024
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
1fa42d9
add default compressor to config
brokkoli71 02053e9
modify _default_compressor to _default_filters_and_compressor
brokkoli71 6ac38ea
fix test_metadata_to_dict
brokkoli71 9507e19
wip debugging
brokkoli71 3727b4a
Merge branch 'master' into default-compressor
brokkoli71 f93ced2
format
brokkoli71 07590ca
fix v2 decode string dtype
brokkoli71 4e2a3bc
fix config default tests
brokkoli71 0fc7b23
format
brokkoli71 35849c7
Merge branch 'main' into default-compressor
brokkoli71 8ec16e8
Update src/zarr/codecs/_v2.py
normanrz d6dc146
rename v2_dtype_kind_to_default_filters_and_compressor to v2_default_…
brokkoli71 78ab221
merge main into default-compressor
brokkoli71 15577ae
recover test_v2.py
brokkoli71 67010ce
incorporate feedback
brokkoli71 f6b98c3
incorporate feedback
brokkoli71 fcbae8b
fix mypy
brokkoli71 75a858d
Merge remote-tracking branch 'origin/default-compressor' into default…
brokkoli71 a77fb0d
allow only one default compressor
brokkoli71 d11bf30
Merge remote-tracking branch 'refs/remotes/upstream/main' into defaul…
brokkoli71 876e67d
put `v2_default_compressor` under `array`
brokkoli71 12dfaf4
deprecate zarr.storage.default_compressor
brokkoli71 6954b60
test v3_default_codecs
brokkoli71 80dfc40
use v3_default_codecs
brokkoli71 6001e93
fix tests that expected codecs==["bytes"]
brokkoli71 ff76617
fix test_default_codecs
brokkoli71 f04e0e6
fail-fast: false
brokkoli71 f63bb67
fix string codecs for np1.25
brokkoli71 00e241e
format
brokkoli71 58406c8
add docstrings to create in asynchronous.py and array.py
brokkoli71 fc09989
add docstrings to creation in group.py
brokkoli71 eed4427
Merge branch 'main' into default-compressor
brokkoli71 c62aff5
Apply suggestions from code review
brokkoli71 48c7448
apply suggestions from review
brokkoli71 083c4cb
correct code double backticks
brokkoli71 500bc7b
correct attribute links in docstring
brokkoli71 cdf5542
link zarr.core.config in docstrings
brokkoli71 43307b3
Merge branch 'main' into default-compressor
brokkoli71 390c435
improve docstring readability
brokkoli71 35e35c4
correct config docstring
brokkoli71 92de85c
correct config docstring
brokkoli71 6fd3f25
improve config docstring
brokkoli71 ea228ca
Merge branch 'main' into default-compressor
normanrz 3933c05
Merge branch 'main' into default-compressor
normanrz 9ac82d1
Merge branch 'main' into default-compressor
normanrz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.