Skip to content

Explicitly clear store in hypothesis strategy #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Explicitly clear store in hypothesis strategy #2481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec058cd
Explicitly clear store in hypothesis strategy
dcherian Nov 11, 2024
7a92479
Merge branch 'main' into fix-hypothesis
d-v-b Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/zarr/testing/strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

from zarr.core.array import Array
from zarr.core.group import Group
from zarr.core.sync import sync
from zarr.storage import MemoryStore, StoreLike

# Copied from Xarray
Expand Down Expand Up @@ -42,7 +43,7 @@ def v2_dtypes() -> st.SearchStrategy[np.dtype]:
| npst.complex_number_dtypes(endianness="=")
| npst.byte_string_dtypes(endianness="=")
| npst.unicode_string_dtypes(endianness="=")
| npst.datetime64_dtypes()
| npst.datetime64_dtypes(endianness="=")
# | npst.timedelta64_dtypes()
)

Expand All @@ -62,7 +63,10 @@ def v2_dtypes() -> st.SearchStrategy[np.dtype]:
attrs = st.none() | st.dictionaries(_attr_keys, _attr_values)
keys = st.lists(node_names, min_size=1).map("/".join)
paths = st.just("/") | keys
stores = st.builds(MemoryStore, st.just({}), mode=st.just("w"))
# st.builds will only call a new store constructor for different keyword arguments
# i.e. stores.examples() will always return the same object per Store class.
# So we map a clear to reset the store.
stores = st.builds(MemoryStore, st.just({})).map(lambda x: sync(x.clear()))
compressors = st.sampled_from([None, "default"])
zarr_formats: st.SearchStrategy[Literal[2, 3]] = st.sampled_from([2, 3])
array_shapes = npst.array_shapes(max_dims=4, min_side=0)
Expand Down