-
-
Notifications
You must be signed in to change notification settings - Fork 329
Bootstrap release notes post v3 #2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -329,10 +329,16 @@ Release procedure | |
Most of the release process is now handled by GitHub workflow which should | ||
automatically push a release to PyPI if a tag is pushed. | ||
|
||
Before releasing, make sure that all pull requests which will be | ||
included in the release have been properly documented in | ||
`docs/release.rst`. | ||
|
||
Pre-release | ||
""""""""""" | ||
1. Make sure that all pull requests which will be | ||
included in the release have been properly documented in | ||
:file:`docs/release-notes.rst`. | ||
2. Rename the "Unreleased" section heading in :file:`docs/release-notes.rst` | ||
to the version you are about to release. | ||
|
||
Releasing | ||
""""""""" | ||
To make a new release, go to | ||
https://github.com/zarr-developers/zarr-python/releases and | ||
click "Draft a new release". Choose a version number prefixed | ||
|
@@ -355,5 +361,8 @@ https://readthedocs.io. Full releases will be available under | |
pre-releases will be available under | ||
`/latest <https://zarr.readthedocs.io/en/latest>`_. | ||
|
||
Also review and merge the https://github.com/conda-forge/zarr-feedstock | ||
pull request that will be automatically generated. | ||
Post-release | ||
"""""""""""" | ||
|
||
- Review and merge the pull request on the `conda-forge feedstock <https://github.com/conda-forge/zarr-feedstock>`_ that will be automatically generated. | ||
- Create a new "Unreleased" section in the release notes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And another commit here? |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems a bit annoying because it requires another commit before the release or am I understanding it wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's right. I guess with the current system, unless we decide on the version numbering ahead of time then this is unavoidable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On other projects I've used https://towncrier.readthedocs.io/en/stable/ with success, and it was suggested a while ago here too: #829.
You still have to generate the changelog before release, but it makes having multiple branches easier (e.g., if we have a 3.0.x branch for bugfixes and
main
for 3.x.0 releases), and would mean the extra commit after release (your comment below) wouldn't be needed.I'd be up for trying to set towncrier up, either instead of or after this PR?