-
-
Notifications
You must be signed in to change notification settings - Fork 329
Array creation with strings for filters, serializer, compressors #2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Array creation with strings for filters, serializer, compressors #2839
Conversation
tests/test_array.py
Outdated
zarr_format=2, | ||
filters="delta", | ||
) | ||
msg = "TransposeCodec.__init__() missing 1 required keyword-only argument: 'order'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think this kind of error message is the best outcome here. it would be better to have an error like "you provided the string foo, which specifies codec fooCodec, but that codec cannot be specified by a string because it takes a required configuration. use either the dict form of fooCodec, or pass in a concrete fooCodec instance instead"
i think this is a good idea, and for codecs that have simple defaults (blosc and gzip and most conventional compressors), it's very user-friendly. but IMO we need to give users a very clear error when they use a string name for a codec that takes required parameters. |
TODO:
docs/user-guide/*.rst
changes/