Add other open modes in group creation test #2840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: asim <[email protected]>
github-actions
bot
added
the
needs release notes
Signed-off-by: asim <[email protected]>
d-v-b
reviewed
Feb 24, 2025
| @@ -1086,10 +1086,16 @@ async def test_open_falls_back_to_open_group_async() -> None: | |||
| assert group.attrs == {"key": "value"} | |||
|
|
|||
|
|
|||
| def test_open_mode_write_creates_group(tmp_path: pathlib.Path) -> None: | |||
| @pytest.mark.parametrize("mode", ["r", "r+", "w", "a"]) | |||
| def test_open_modes_creates_group(tmp_path: pathlib.Path, mode: str) -> None: | |||
There was a problem hiding this comment.
we should test this for every store class, but I think that can be a future PR
There was a problem hiding this comment.
Agreed! looking forward to work on it and raise a PR
d-v-b
reviewed
Feb 24, 2025
Add else block for write operations only Co-authored-by: Davis Bennett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Description of PR]
fixes: #2630
TODO:
docs/user-guide/*.rstchanges/