Skip to content

Use a dictionary comprehension instead #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2025
Merged

Use a dictionary comprehension instead #3029

merged 2 commits into from
May 3, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Apr 30, 2025 •
edited
Loading

Suggested by DeepSource. This micro-optimisation might be faster, but I'm not convinced it improves readability/maintainability.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 30, 2025
dstansby
dstansby approved these changes May 3, 2025
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this i a bit better actually

@dstansby dstansby enabled auto-merge (squash) May 3, 2025 21:02
@dstansby dstansby merged commit 213863b into zarr-developers:main May 3, 2025
29 of 30 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PYL-R1717 branch May 4, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dstansby dstansby dstansby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimitriPapadopoulos @dstansby