add fill_value output to info #3081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
commented
May 22, 2025
docs/user-guide/arrays.rst
Outdated
Comment on lines
214
to
215
| No. bytes stored : 9696520 | ||
| Storage ratio : 41.3 |
There was a problem hiding this comment.
this looks off-target from my PR, curious how this change slipped in
There was a problem hiding this comment.
Seeing the same thing in my PR
There was a problem hiding this comment.
Ah, this is possibly because of the yanked numcodecs?
There was a problem hiding this comment.
Ah I was unaware numcodecs had been yanked, ok that's probably it then.
|
As suspected, re-running the tests now numcodecs 0.16.1 is out fails - could you re-(re?)-fix the doctest, otherwise this looks good to me 👍 |
dstansby
approved these changes
May 25, 2025
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the array's fill value to the output of
info.