Add with_read_only() convenience method to store #3138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
maxrjones
commented
Jun 18, 2025
dstansby
reviewed
Jun 18, 2025
dstansby
approved these changes
Jun 19, 2025
|
@meeseeksdev backport to 3.0.9 |
meeseeksmachine
pushed a commit
to meeseeksmachine/zarr-python
that referenced
this pull request
Jun 30, 2025
d-v-b
pushed a commit
that referenced
this pull request
Jun 30, 2025
…3181) Co-authored-by: Max Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Store.with_read_only()convenience method to create a new store with a different read mode. By default, the method raises aNotImplementedError. The motivation is to make it simpler for downstream libraries to adapt to the changes in #3068. For example, this would make it much simpler to address the 269 failures in Xarray's upstream test suite and the failures in VirtualiZarr's upstream test suite.This is similar to the functionality added in #2249 and removed in #2442. @jhamman would you be able to offer any details on the motivation for previously removing the similar functionality?
TODO:
docs/user-guide/*.rstchanges/