Skip to content

Conversation

LDeakin
Copy link
Member

@LDeakin LDeakin commented Jul 12, 2025

This enables the zarrs-python CodecPipeline to support a broader range of Zarr arrays and to construct store wrappers on initialisation. I've tried to write this so that it is an entirely non-breaking change.

I've trialled this here zarrs/zarrs-python@263a55c.

xref:

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

This enables fancy `CodecPipeline` implementations like `zarrs-python` to support a broader range of Zarr arrays and to construct store wrappers on initialisation.
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 12, 2025
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (ea4d7e9) to head (306d040).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3233   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          78       78           
  Lines        8710     8718    +8     
=======================================
+ Hits         8254     8262    +8     
  Misses        456      456           
Files with missing lines Coverage Δ
src/zarr/abc/codec.py 93.93% <100.00%> (+0.28%) ⬆️
src/zarr/core/array.py 98.53% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LDeakin LDeakin marked this pull request as ready for review July 12, 2025 08:56
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I had 1 suggestion about making the store argument keyword-only

LDeakin and others added 2 commits July 12, 2025 22:17
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jul 12, 2025
@d-v-b d-v-b merged commit 455b4f9 into zarr-developers:main Jul 12, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants