-
-
Notifications
You must be signed in to change notification settings - Fork 356
chore/remove chunk coords #3374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
commented
Aug 13, 2025
ShapeLike = tuple[int, ...] | int | ||
ChunkCoords = tuple[int, ...] | ||
ChunkCoordsLike = Iterable[int] | ||
ShapeLike = Iterable[int] | int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this change, which better matches the intent of ShapeLike
.
TomAugspurger
approved these changes
Aug 17, 2025
…ore/remove-chunk-coords
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3374 +/- ##
==========================================
- Coverage 94.55% 94.55% -0.01%
==========================================
Files 79 79
Lines 9448 9447 -1
==========================================
- Hits 8934 8933 -1
Misses 514 514
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces all
occurrencesusage ofChunkCoords
withtuple[int, ...]
I do keep the
ChunkCoords
definition inzarr.core.common
in case someone was using it, since we do have people using our private API in the wild. Happy to remove this if people think it's safe.closes #3373