Skip to content

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Sep 11, 2025

Fixes #3447 by widening the permitted types of integer fill values to include "int-ish floats", e.g. 1.0 or 0.0.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Sep 11, 2025
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.06%. Comparing base (d3fa3f5) to head (07c9990).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/zarr/core/dtype/npy/common.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3448      +/-   ##
==========================================
- Coverage   61.07%   61.06%   -0.01%     
==========================================
  Files          79       79              
  Lines        9500     9506       +6     
==========================================
+ Hits         5802     5805       +3     
- Misses       3698     3701       +3     
Files with missing lines Coverage Δ
src/zarr/core/dtype/npy/int.py 53.29% <100.00%> (+0.29%) ⬆️
src/zarr/core/dtype/npy/common.py 60.18% <25.00%> (-1.36%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Sep 12, 2025
@d-v-b d-v-b enabled auto-merge (squash) September 12, 2025 15:20
@d-v-b d-v-b merged commit 4011d51 into zarr-developers:main Sep 12, 2025
31 checks passed
@d-v-b d-v-b deleted the fix/relax-int-fill-value branch September 12, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zarr v3: TypeError on float fill_value "0.0" for uint8 arrays—compatibility with legacy datasets
2 participants