-
-
Notifications
You must be signed in to change notification settings - Fork 329
Mutable mapping for Azure Blob #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
90 commits
Select commit
Hold shift + click to select a range
fd5bfb5
basic implementation working
rabernat a26752c
docs and cleanup
rabernat 23dd8f6
fixed client_kwargs bug
rabernat dec75dd
Add ABSStore mutable mapping
13c2077
Fix import syntax
86603fa
Get open_zarr() working
tjcrone 4b999ba
Change account variable names
tjcrone 677ec1c
Fix client.exists() logging issue
tjcrone d9be9ba
Minor comment changes
tjcrone 13b1ee8
Get to_zarr() working
tjcrone e5564c3
Remove state['container'] delete
tjcrone a85e559
Implement rmdir
tjcrone 272d234
Add docstring for ABSStore
tjcrone bb406a0
Remove GCSStore from this branch
tjcrone 937d162
Fixed missing argument in getsize of ABStore
mzjp2 74920c4
Specified prefix argument in rmdir for abstore
mzjp2 bd1648b
Fixed join string error in dir_path in ABStore
mzjp2 e79cb4f
Merge pull request #2 from mzjp2/abs_store
tjcrone 0e71f70
Remove logging work-around as the issue was fixed in azure-storage 1.3.0
tjcrone de5bb9c
Clean up docstring
tjcrone 13a6d30
Remove more GCSStore code
tjcrone 7b52e39
Move utility functions into ABSStore class
tjcrone 29a8697
Merge pull request #288 from friedrichknuth/abs_store
tjcrone 36139cb
implemented the rest of the mutable mapping functions. tests pass wit…
shikharsg bda0c3f
using local blob emulator for storage.ABSStore testing
shikharsg 447c473
fixed PY2 array.array error in storage.ABSStore
shikharsg c6858ed
create test container if not exists in ABSStore test
shikharsg 8e51b3b
added more tests for ABSStore
shikharsg ec4e3f1
reverted blob client creation to inside of ABSStore
shikharsg bde7b5e
added group test for ABSStore
shikharsg b86cf53
emulator connection string not needed
shikharsg f66dadd
fixed import statement location and put azure-storage-blob in require…
shikharsg b8f60fe
fixed pickle tests
shikharsg edd5a71
fixed listdir in ABSStore
shikharsg 3fbe589
fixed getsize
shikharsg 4b8560e
Fixed PY2 pickle test. python 2 pickle can't pickle instance methods
shikharsg 631051c
implemented the suggestion from here: https://github.com/zarr-develop…
shikharsg ea93352
flake-8 fixes
shikharsg dd17cd4
merged master with abs_store
shikharsg 08fe155
added azure-storage-blob
shikharsg 957b405
first attempt at docker build with azurite
shikharsg 9c128db
azure storage emulator in appveyor
shikharsg 2da2453
syntax correction
shikharsg a09e2c9
checking if emulator is preinstalled
shikharsg 5ce6a4c
syntax fix
shikharsg bf8aa37
syntax fix
shikharsg 730255c
syntax fix
shikharsg 8dc2f5d
removed wrong syntax
shikharsg 85a5670
storage emulator with docker
shikharsg b2cda56
merged abs_store with upstream
shikharsg a09fb61
trying different appveyor image
shikharsg 168ba50
flake 8 fixes
shikharsg e0de99b
full coverage
shikharsg 3efe802
verbose logs for pip install to see appveyor error
shikharsg 8f85315
trying to run locally installed emulator
shikharsg d1bb9ce
single-double quote yaml fix
shikharsg 735c661
cmd prefix
shikharsg 979a438
double quotes around exe file path
shikharsg 5beace1
double quotes within single quotes with environment variable substitu…
shikharsg 68bda4e
trying appveyor build with VS2015 image
shikharsg 77db637
added comment and removed verbosity option for pip install
shikharsg bcdc839
list_abs_directory to list only directory blob using delimiter option…
shikharsg ac286ce
fixed ABSStore docs
shikharsg cdaceb7
fixed windows path listdir error
shikharsg b6b3024
ABSStore refactoring
shikharsg b6eebc8
moved py2 array.array checking to numcodecs ensure bytes
shikharsg 101be91
Merge branch 'master' into abs_store
shikharsg 3abe79d
syntax fix
shikharsg 3ad6d9c
flake8 fix
shikharsg ab38119
fixed ABSStore parameter name container
shikharsg 05aab41
removed context manager from ABSStore
shikharsg 90b5e3a
ABSStore.__delitem__ now takes only 1 azure storage API call
shikharsg 4636d5d
docs
shikharsg 8c3863f
Update zarr/storage.py
alimanfoo b238f0b
removed global import of azure storage library
shikharsg 9770876
added ABSStore to zarr root import
shikharsg 3ed4814
added ABSStore to tutorial.rst
shikharsg 7b08aba
fixed docs
shikharsg 6fc869d
trying to fix tutorial.rst
shikharsg e9a402e
flake8 fix
shikharsg 8aa3a01
fixing tutorial.rst
shikharsg a9940a2
fixed ABSStore in tutorial
shikharsg 4d5b6d1
docs
shikharsg 45b0642
Merge branch 'master' into abs_store
shikharsg 3a4f4d9
small change to docs
shikharsg 1da44b1
Merge branch 'abs_store' of github.com:shikharsg/zarr into abs_store
shikharsg b51fb78
cleaned create blob code
4af5ebe
flake8 fix
13a7dc4
Update docs/release.rst
alimanfoo a062e18
Apply suggestions from code review
alimanfoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,3 +9,4 @@ pytest-cov | |
s3fs | ||
setuptools-scm | ||
tox | ||
azure-storage-blob |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, this may move to an
azure
org on Docker Hub ( Azure/Azurite#94 ), but it hasn't happened yet. Happy with leaving this as is. Just raising awareness.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pointing out