Use scandir in DirectoryStore.getsize #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `scandir` was added to the `os` module in Python 3.5, require the backport package for `scandir` is installed for versions prior to that (e.g. Python 2.7).
|
Thoughts @zarr-developers/core-devs ? |
|
lgtm |
|
Agreed, looks good. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
DirectoryStore.getsizeimplementation to usescandir. This is significantly faster than just usinglistdir(especially as we are checking whether the item is a file and what it's size is). This is included in Python 3.5+. For older versions of Python we require thescandirpackage from PyPI.TODO:
tox -e docs)