Skip to content

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jan 9, 2020

Includes some other Changelog entries for 2.4.

xref: #529

cc @jrbourbeau

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

docs/release.rst Outdated
~~~~~~~~~

* Fix Sqlite Store Wrong Modification.
By :user:`potter420 <potter420>`; :issue:`440`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potter420, are you ok being listed here? How would you like to be referred to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to be referred to as Tommy Tran.
My current name is kinda goofy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks. Have pushed in the latest commit. Can you please let me know whether I got that correct?

@jakirkham
Copy link
Member Author

@jrbourbeau, could you please take a look and let me know if I'm missing anything?

@jrbourbeau
Copy link
Member

Thanks @jakirkham, apologies for not getting to this earlier. I'm stepping away from my laptop for a few hours, but will review later this evening

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this @jakirkham! I added "Enhancements", "Documentation", and "Maintenance" sections in line with previous release notes and changelog entries for a few PRs (mostly small documentation updates).

I think the only remaining things are to update Upcoming Release to 2.4.0 and add a .. _release_2.4.0: marker

@jakirkham
Copy link
Member Author

Thanks for doing that @jrbourbeau! Looks good. Added those missing pieces and merged with master. Please let me know if anything else is needed 🙂

@jrbourbeau
Copy link
Member

I'll go through the release procedure docs and see if there are any updates to be made there. Other than that, we should be good to release (woo!)

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to merge this and push to PyPI

@jakirkham
Copy link
Member Author

Push away! 😄

@jrbourbeau jrbourbeau merged commit 994f244 into zarr-developers:master Jan 11, 2020
@jakirkham jakirkham deleted the add_2.4_changelog branch January 11, 2020 01:16
@Carreau Carreau added this to the v2.4 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants