Skip to content

Reduce number of store queries in open(mode='a'). #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Reduce number of store queries in open(mode='a'). #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions zarr/convenience.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,8 @@ def open(store=None, mode='a', **kwargs):
else:
return open_group(store, mode=mode, **kwargs)

elif mode == 'a':
if contains_array(store, path):
return open_array(store, mode=mode, **kwargs)
elif contains_group(store, path):
return open_group(store, mode=mode, **kwargs)
elif 'shape' in kwargs:
elif mode == "a":
if "shape" in kwargs or contains_array(store, path):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if "shape" in kwargs or contains_array(store, path):
if ("shape" in kwargs) or contains_array(store, path):

return open_array(store, mode=mode, **kwargs)
else:
return open_group(store, mode=mode, **kwargs)
Expand Down