Skip to content

Remove error utils function (not used anymore) #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Sep 22, 2020

Convert also one more err_ function into a proper exception that derives
from ValueError.

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

@Carreau Carreau marked this pull request as ready for review September 22, 2020 15:55
Convert also one more err_ function into a proper exception that derives
from ValueError.
@pep8speaks
Copy link

pep8speaks commented Sep 23, 2020

Hello @Carreau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-30 17:50:01 UTC

@Carreau Carreau added this to the v2.5 milestone Sep 30, 2020
@jakirkham jakirkham merged commit 9fe9a0e into zarr-developers:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants