Skip to content

Use github workflow to build sdist/wheel and upload. #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2020

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Sep 28, 2020

Setup a github workflow based on numcodec to build sdist and wheel. Adapted from numcodec.
I have to check what ciwheel do, as zarr wheels are likely universal and dont' need to be per-platform

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

@Carreau
Copy link
Contributor Author

Carreau commented Sep 28, 2020

I switched from cibuildwheel to "build" which is a non-official pep518 packed (hence adding the Pyproject.toml file as well).

@Carreau Carreau marked this pull request as ready for review September 28, 2020 23:04
@jakirkham
Copy link
Member

Do we need to do anything special to indicate the wheel is not architecture dependent?

@Carreau
Copy link
Contributor Author

Carreau commented Sep 29, 2020

Do we need to do anything special to indicate the wheel is not architecture dependent?

not as far as I can tell, I think that's one of the main difference between build and cibuildwheel.
on a non-tagged repository I get

$ ls -1 dist/
zarr-2.4.1.dev69+dirty-py3-none-any.whl
zarr-2.4.1.dev69+dirty.tar.gz

Indicating the wheel is compatible all platforms.

use `build` to build both a sdist and a platform independant wheel on
tagging.
@Carreau
Copy link
Contributor Author

Carreau commented Sep 29, 2020

Currently testing on myfork [https://github.com/Carreau/zarr-python/actions], the action does not work correctly yet.

@Carreau Carreau added this to the v2.5 milestone Sep 30, 2020
@Carreau Carreau merged commit 44053d6 into zarr-developers:master Oct 5, 2020
@Carreau Carreau deleted the autorelease branch October 5, 2020 18:48
@jakirkham
Copy link
Member

Thanks Matthias! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants