Add guard as to version number; #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
approved these changes
Dec 2, 2020
Carreau
force-pushed
the
triple-zero-check
branch
from
1ae5c8a to
611e732
Compare
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 10093 10094 +1
=========================================
+ Hits 10093 10094 +1
|
It seem like setuptools scm can screw up and this should ensure we catch that in CI before making the wheel. We want to make sure to have a runtime check for the version number as well as a check just after building the wheel. This seem to be due to `build` latest version, so i've pinned it for now.
Carreau
force-pushed
the
triple-zero-check
branch
from
475ffb1 to
c32a7a3
Compare
|
Ok, downgrading build to 0.4 seem to work for now, I'm going to merge and tag a 2.6.1, and work on a proper fix later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seem like setuptools scm can screw up and this should ensure we catch
that in CI before making the wheel.