Skip to content

Updated ipytree warning for jlab3 #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Conversation

ianhi
Copy link
Contributor

@ianhi ianhi commented Apr 23, 2021

Jupyterlab 3 changed how widgets are installed. Now both the frontend and backend are installed via pip/conda. If a user also then installs the front using the jupyter labextension install command then they can end up breaking things by trying to install
an old version. This should hopefully help avoid leading users astray.

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • [NA] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [NA] New/modified features documented in docs/tutorial.rst
  • [NA?] Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Jupyterlab 3 changed how widgets are installed. Now both the
frontend and backend are installed via pip/conda. If a user
also then installs the front using the `jupyter labextension install`
command then they can end up breaking things by trying to install
an old version.
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #721 (efc1509) into master (03dce69) will decrease coverage by 0.48%.
The diff coverage is n/a.

❗ Current head efc1509 differs from pull request most recent head cfd96a2. Consider uploading reports for the commit cfd96a2 to get more accurate results

@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   99.94%   99.45%   -0.49%     
==========================================
  Files          28       28              
  Lines       10442    10328     -114     
==========================================
- Hits        10436    10272     -164     
- Misses          6       56      +50     
Impacted Files Coverage Δ
zarr/tests/test_util.py 100.00% <ø> (ø)
zarr/util.py 85.50% <ø> (-14.50%) ⬇️
zarr/n5.py 100.00% <0.00%> (ø)
zarr/core.py 100.00% <0.00%> (ø)
zarr/meta.py 100.00% <0.00%> (ø)
zarr/storage.py 100.00% <0.00%> (ø)
zarr/creation.py 100.00% <0.00%> (ø)
zarr/hierarchy.py 100.00% <0.00%> (ø)
zarr/tests/test_core.py 100.00% <0.00%> (ø)
... and 3 more

@joshmoore joshmoore merged commit b170a48 into zarr-developers:master Apr 29, 2021
@ianhi ianhi deleted the jlab-warn branch April 29, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants