Skip to content

Pass dimension_separator on fixture generation (fix #858) #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/minimal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,10 @@ jobs:
conda activate minimal
python -m pip install .
pytest -svx
- name: Fixture generation
shell: "bash -l {0}"
run: |
conda activate minimal
rm -rf fixture/
pytest -svx zarr/tests/test_dim_separator.py zarr/tests/test_storage.py
# This simulates fixture-less tests in conda and debian packaging
10 changes: 9 additions & 1 deletion zarr/tests/test_dim_separator.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import pytest
from numpy.testing import assert_array_equal
from functools import partial

import zarr
from zarr.core import Array
Expand Down Expand Up @@ -43,9 +44,16 @@ def dataset(tmpdir, request):
if not static.exists(): # pragma: no cover

if "nested" in which:
# No way to reproduce the nested_legacy file via code
generator = NestedDirectoryStore
else:
generator = DirectoryStore
if "legacy" in suffix:
# No dimension_separator metadata included
generator = DirectoryStore
else:
# Explicit dimension_separator metadata included
generator = partial(DirectoryStore,
dimension_separator=".")

# store the data - should be one-time operation
s = generator(str(static))
Expand Down