Add StoreV3 support to Attributes (zarr v3 support part 2) #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the StoreV3 class and create v3 versions of most existing stores Add a test_storage_v3.py with test classes inheriting from their v2 counterparts. Only a subset of methods involving differences in v3 behavior were overridden.
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
- Coverage 99.94% 98.08% -1.86%
==========================================
Files 32 33 +1
Lines 11216 12401 +1185
==========================================
+ Hits 11210 12164 +954
- Misses 6 237 +231
|
6 tasks
grlee77
force-pushed
the
v3-store-part2
branch
from
2cbbe77 to
e7a8dce
Compare
avoid pytest error about missing fixture fix flake8 error related to zarr_version fixture
grlee77
force-pushed
the
v3-store-part2
branch
from
e7a8dce to
27579c3
Compare
|
closing, these commits along with additional fixes and tests are incorporated in #898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #874, updating just the Attributes class to support the v3 spec (only commit c42433d is new at this time)
The test cases here take a different approach than in #874, just adding a fixture to parameterize the tests over the zarr versions. This results in relatively small diffs to the test file.
TODO: