Skip to content

Proper C-style formatting for integer #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

DimitriPapadopoulos
Copy link
Contributor

Variable port is initialized as an integer, should be formatted with %d.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Variable `port` is initialized as an integer, should be formatted with `%d`.
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #913 (d364fff) into master (1711b16) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #913   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          32       32           
  Lines       11216    11216           
=======================================
  Hits        11210    11210           
  Misses          6        6           
Impacted Files Coverage Δ
zarr/tests/test_storage.py 100.00% <100.00%> (ø)

@joshmoore joshmoore merged commit dd8fa23 into zarr-developers:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants