Ignore Intellij/PyCharm project files #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Josh! 🙏 Are we interested in ignoring these too? Or are those not something we need to worry about? |
|
Guess I'm a bit hesitant to try to capture all the possible builds and tools. I'd be inclined to wait until others rear their head, but if you'd prefer: happy to add Maven etc. here. Sidenote: I'm going to ignore the build failure since I'm working on a more general solution in #57 |
|
Should we go ahead and merge? |
|
Going to go ahead and merge since this is a useful change on its own and CI isn't related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to .gitinore:
see #58 and #59