Reference endpoints by address, not number. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An endpoint address is made up of two nibbles. The upper nibble specifies the endpoint direction, and the lower nibble is the endpoint number. libusbpp currently treats endpoint numbers as unique, which is problematic in the case of a bidirectional endpoint (eg addresses 0x04 and 0x84.) Change the API to reference endpoints by address, not number.
|
In reality 0x04 and 0x84 are two different endpoint in the context of USB. The only bi-directional endpoint is the control endpoint (usually EP0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An endpoint address is made up of two nibbles. The upper nibble specifies
the endpoint direction, and the lower nibble is the endpoint number.
libusbpp currently treats endpoint numbers as unique, which is
problematic in the case of a bidirectional endpoint (eg addresses 0x04
and 0x84.)
Change the API to reference endpoints by address, not number.