Skip to content

fix: call should_attach on sign_in #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

powerman
Copy link
Contributor

@powerman powerman commented Jul 4, 2025

This is a security issue: starting nvim .env currently result in attaching copilot (ignoring should_attach callback).

Fixes #505

@AntoineGS AntoineGS merged commit b0ffa35 into zbirenbaum:master Jul 8, 2025
@powerman powerman deleted the fix-should_attach-on-sign_in branch July 8, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should_attach is not called on sign_in
2 participants