Zed (Not Responding) after 0.10.0 update

[lipedjow]

After updating to 0.10.0 Zed is constantly hanging (Not Responding)
Not sure why, still trying to figure out.. seems to be related to Herb indexing/parsing.
Reverting to 0.9.0 works fine.

0.9.0

0.10.0

[marcoroth]

Hey @lipedjow, thanks for opening this issue. Herb itself currently doesn't batch index/parse files, it only parses the HTML+ERB files you open. Would you mind running herb standalone to see if it's related to Herb crashing in some way or form?

cd your_project/

gem install herb

herb analyze .

Thank you!

[lipedjow]

Hey,

Ah, I see! Indeed it only hangs on HTML+ERB file.
Actually I couldn't inspect much as it keeps hanging.

Sure! It runs fine and give me this result:

Let me know if there's anything else to check.

Cheers!

[marcoroth]

Oh this "Timed out" one might explain it. We probably need to add a timeout in the language server too when trying parsing a file, I'll add that.

But more interestingly, can you check the *.log file it generated to see which file it is. And if you are able to, would you mind sharing that file? Feel free to email it to me if you don't want to / can't share it publicly.

[lipedjow]

Sure thing! Let me just check something on that.. one sec

[lipedjow]

Timed out file was the one I was working with, a static html file that I started adding some Ruby to it. Issue happens when I opened an each block (with several html elements inside) and didn't close it (actually it hangs before being able to).

Interesting thing is that after you've asked to install herb manually, I couldn't reproduce the issue anymore.
But removing herb gem triggers the issue again.

I can share the log file and/or the html+erb with you if you still want.

[marcoroth]

Interesting!

The Ruby gem should have absolutely nothing to do with the LSP, because the whole Language Server runs in Node.js, so that wouldn't be very weird if that had any influence.

I'd love to see the HTML+ERB file if you can share it (or reduce it to the minimum that is able to let it crash). Thank you!

[lipedjow]

Nice! I'll prepare the file when I have the chance and share with you.

BTW, thank you for the awesome work on Herb and all other OSS contributions! Congrats!