Skip to content

feat(dropdowns): add navigation link support to Menu's Item component #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 15, 2025
Merged

feat(dropdowns): add navigation link support to Menu's Item component #2021

merged 9 commits into from
May 15, 2025

Conversation

ze-flo
Copy link
Contributor

@ze-flo ze-flo commented May 14, 2025

Description

This PR enhances the Menu's Item component by adding support for navigational links.

Details

  • Added two optional props to Menu Item:
    • href: When provided, the menu item is rendered as an anchor.
    • isExternal: When true, adds appropriate attributes (target="_blank" and rel="noopener noreferrer") to external links.
  • Ensures compliance with the ARIA Menu Button Link pattern

Screenshot 2025-04-21 at 2 53 34 PM
Screenshot 2025-04-21 at 2 53 22 PM

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ⚫ renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

geotrev and others added 7 commits June 27, 2024 11:58
@geotrev
feat(dropdowns): enables menu item as link
da0bebe
@ze-flo
Merge branch 'main' of github.com:zendeskgarden/react-components into…
aeac589 
… george/menu-links

# Conflicts:
#	packages/dropdowns/src/elements/menu/Item.tsx
#	packages/dropdowns/src/views/combobox/StyledOption.ts
#	packages/dropdowns/src/views/menu/StyledItem.ts
#	packages/dropdowns/src/views/menu/StyledItemContent.ts
#	packages/dropdowns/src/views/menu/StyledItemIcon.ts
@ze-flo
refactor(menu): remove external link icon, fix keyboard behavior on l…
a2fb9cd 
…ink, clean up
@ze-flo
test(Menu): add Item with link specs
cf77156
@ze-flo
chore: clean up story data
15e0ba4
@ze-flo
chore: PR feedback
c4b0891
@ze-flo
refactor(dropdowns menu): use container-menu getAnchorProps getter
dd36fc7
@ze-flo ze-flo mentioned this pull request May 14, 2025
Closed
8 tasks
@ze-flo ze-flo mentioned this pull request May 14, 2025
Closed
8 tasks
@coveralls
Copy link

coveralls commented May 14, 2025 •
edited
Loading

Coverage Status

coverage: 95.511% (+0.007%) from 95.504%
when pulling b135533 on ze-flo/menu-link-menu-items
into e16818a on main.

@ze-flo ze-flo marked this pull request as ready for review May 14, 2025 20:59
@ze-flo ze-flo requested a review from a team as a code owner May 14, 2025 20:59
jzempel
jzempel requested changes May 14, 2025
View reviewed changes
@jzempel jzempel merged commit 5ae8aba into main May 15, 2025
8 checks passed
@jzempel jzempel deleted the ze-flo/menu-link-menu-items branch May 15, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

Assignees
No one assigned
Labels
PR: New Feature 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ze-flo @coveralls @jzempel @geotrev