fix: make sure fields inherited from abstract base models are properly recognized as id

[ymc9]

Fixes #1129

Summary by CodeRabbit

• Bug Fixes
  • Improved the logic for identifying ID fields to handle inherited fields and unique scenarios more accurately.
• Tests
  • Added a new test case to cover a regression related to database schema operations.

[coderabbitai]

Walkthrough

Walkthrough

This update involves refining the logic for identifying ID fields in the SDK's utility functions and introducing a regression test for a specific issue. The changes aim to ensure accurate ID field recognition, particularly in scenarios involving inherited fields or unique situations, and to validate the resolution of a regression related to compound primary keys in models derived from abstract models.

Changes

File Path	Change Summary
packages/sdk/src/utils.ts	Updated logic for identifying ID fields by comparing field names.
tests/integration/tests/regression/...test.ts	Added a test case for regression related to compound primary keys and abstract models.

Assessment against linked issues

Objective	Addressed	Explanation
Issue #1129: Ensure select statement includes relation1Id and relation2Id	✅
Issue #1129: Address ID generation issue for models with compound primary keys	✅
Issue #1129: Test updated code for correct select statement inclusion	✅

Related issues

• Zenstack does not let me define multiple fields that are referencing the same model #653: This issue might be indirectly related due to its focus on model relationships and referencing. The update to ID field identification could potentially impact how relationships are handled, especially in complex scenarios involving multiple references to the same model.
• Error when generating from schema with polymorphic models - given constraint name ... has to be unique in the following namespace... #1058: Although this issue is more focused on polymorphic models and uniqueness constraints in schema generation, the improved ID field identification logic might indirectly affect the handling of such models by ensuring more accurate identification of ID fields, which could be beneficial in addressing uniqueness constraint errors.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between be9be0c and 58a6ddd.

Files selected for processing (2)

• packages/sdk/src/utils.ts (2 hunks)
• tests/integration/tests/regression/issue-1129.test.ts (1 hunks)

Additional comments: 4

packages/sdk/src/utils.ts (4)

• 221-223: The comment explains the rationale behind using field names instead of references for matching fields, which is crucial for handling inherited fields. This change aligns with the PR objectives and addresses the core issue effectively.
• 228-228: The logic to include fields specified in the model-level @@id attribute by comparing their names is correct and necessary for resolving the issue with compound primary keys.
• 240-240: Ensuring that the first field with @unique can be used as an ID by comparing names is a sensible approach, especially when no @id or @@id attributes are present.
• 245-245: Similarly, the logic to include fields specified in the model-level @@unique attribute by comparing their names is appropriate and helps in correctly identifying ID fields in complex scenarios.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 58a6ddd and f9bc3c8.

Files selected for processing (1)

• tests/integration/tests/regression/issue-1129.test.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• tests/integration/tests/regression/issue-1129.test.ts