Skip to content

fix: missing arg passing to recursion #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: missing arg passing to recursion #1832

merged 1 commit into from
Nov 6, 2024

Conversation

ymc9
Copy link
Member

@ymc9 ymc9 commented Nov 6, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented Nov 6, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request involve a modification to the hasValidationAttributes function in the packages/sdk/src/validation.ts file. The update includes adding a seen parameter to a recursive call within the function, which helps track previously encountered declarations. This adjustment aims to prevent infinite recursion by ensuring that the same declaration is not processed multiple times. The overall function structure and logic remain unchanged, with no additional modifications to control flow or error handling.

Changes

File Change Summary
packages/sdk/src/validation.ts Updated the hasValidationAttributes function to include seen parameter in the recursive call.

Sequence Diagram(s)

Loading
sequenceDiagram
    participant Caller
    participant ValidationFunction
    participant SeenSet

    Caller->>ValidationFunction: hasValidationAttributes(decl, seen)
    ValidationFunction->>SeenSet: Check if decl is in seen
    alt decl not seen
        ValidationFunction->>ValidationFunction: Process decl
        ValidationFunction->>ValidationFunction: hasValidationAttributes(field.type.reference?.ref, seen)
        ValidationFunction->>SeenSet: Add decl to seen
    else decl seen
        ValidationFunction->>Caller: Return false
    end

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
packages/sdk/src/validation.ts (1)

36-36: LGTM! Fixed infinite recursion issue, but could be more robust.

The addition of the seen parameter correctly fixes the infinite recursion issue. However, the optional chaining could be made more robust.

Consider restructuring the optional chaining to avoid potential undefined reference:

-return hasValidationAttributes(field.type.reference?.ref, seen);
+const typeRef = field.type.reference?.ref;
+return typeRef ? hasValidationAttributes(typeRef, seen) : false;

This change:

  1. Makes the code more defensive against undefined references
  2. Improves readability by separating the null check from the function call
  3. Explicitly handles the case when there's no reference
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9cc01d5 and 50825d4.

📒 Files selected for processing (1)
  • packages/sdk/src/validation.ts (1 hunks)
🔇 Additional comments (2)
packages/sdk/src/validation.ts (2)

Line range hint 18-21: LGTM! Well-structured function signature with proper cycle detection.

The function signature is well-designed with appropriate default parameter and TypeScript types. The seen Set is a good choice for tracking visited nodes to prevent infinite recursion.


Line range hint 22-25: LGTM! Proper implementation of cycle detection.

The cycle detection is implemented correctly with early returns and immediate marking of visited nodes.

@ymc9 ymc9 merged commit 13f95d2 into dev Nov 6, 2024
13 checks passed
@ymc9 ymc9 deleted the fix/recursion-seen branch November 6, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant