chore: misc changes for 2.9.0 #1873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ymc9
commented
Nov 18, 2024
ymc9
commented
- Jetbrains changelog update
- Removed redundant new line at the end of generated code
- TRPC test baselines update
- Jetbrains changelog update - Removed redundant new line at the end of generated code - TRPC test baselines update
📝 WalkthroughWalkthroughThe pull request introduces updates to the changelog for the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
packages/ide/jetbrains/CHANGELOG.md (1)
5-7: Remove unnecessary empty line after section headerThe empty line after "### Added" is inconsistent with the formatting of other sections in the changelog.
### Added - - Support for using `@@validate` attribute inside type declarations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (32)
packages/plugins/trpc/tests/projects/nuxt-trpc-v10/server/trpc/routers/generated/client/Post.nuxt.type.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v10/server/trpc/routers/generated/client/User.nuxt.type.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v10/server/trpc/routers/generated/client/nuxt.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v10/server/trpc/routers/generated/client/utils.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v10/server/trpc/routers/generated/helper.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v10/server/trpc/routers/generated/routers/Post.router.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v10/server/trpc/routers/generated/routers/User.router.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v10/server/trpc/routers/generated/routers/index.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v11/server/trpc/routers/generated/client/Post.nuxt.type.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v11/server/trpc/routers/generated/client/User.nuxt.type.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v11/server/trpc/routers/generated/client/nuxt.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v11/server/trpc/routers/generated/client/utils.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v11/server/trpc/routers/generated/helper.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v11/server/trpc/routers/generated/routers/Post.router.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v11/server/trpc/routers/generated/routers/User.router.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/nuxt-trpc-v11/server/trpc/routers/generated/routers/index.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/client/Post.next.type.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/client/User.next.type.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/client/next.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/client/utils.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/helper.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/routers/Post.router.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/routers/User.router.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/routers/index.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v11/src/server/api/routers/generated/client/Post.react.type.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v11/src/server/api/routers/generated/client/User.react.type.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v11/src/server/api/routers/generated/client/react.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v11/src/server/api/routers/generated/client/utils.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v11/src/server/api/routers/generated/helper.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v11/src/server/api/routers/generated/routers/Post.router.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v11/src/server/api/routers/generated/routers/User.router.tsis excluded by!**/generated/**,!**/generated/**packages/plugins/trpc/tests/projects/t3-trpc-v11/src/server/api/routers/generated/routers/index.tsis excluded by!**/generated/**,!**/generated/**
📒 Files selected for processing (2)
packages/ide/jetbrains/CHANGELOG.md(1 hunks)packages/sdk/src/code-gen.ts(1 hunks)
🔇 Additional comments (2)
packages/ide/jetbrains/CHANGELOG.md (1)
7-7: LGTM! Clear and concise feature documentation
The changelog entry effectively communicates the new feature addition and follows the established documentation style.
packages/sdk/src/code-gen.ts (1)
33-33: LGTM! Verify generated code formatting
The indentation change aligns with the PR objective to remove redundant newlines. This should result in cleaner generated code output.
Let's verify the generated code formatting:
✅ Verification successful
Formatting change verified - single newline maintained
The code-gen.ts file maintains exactly one newline at the end of the file, which is the standard formatting practice. The change aligns with the PR objective of removing redundant newlines while preserving proper file formatting.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the formatting of recently generated files to ensure proper indentation
# Find and examine recently modified generated files
find . -type f -name "*.generated.*" -o -name "*.gen.*" -mtime -1 | while read -r file; do
echo "=== Checking formatting of $file ==="
# Check for any lines with only whitespace at the end of the file
tail -n 5 "$file" | awk 'NF==0{print NR": empty line"}'
# Show the last few lines to verify no extra newlines
tail -n 5 "$file"
done
Length of output: 15113
Script:
#!/bin/bash
# Let's search for recently modified files in the repository to find actual generated files
# rather than the node_modules content
# Find files modified in the last day, excluding node_modules
find . -type f -mtime -1 -not -path "*/node_modules/*" -not -path "*/.git/*" | while read -r file; do
# Check if it looks like a generated file
if [[ "$file" =~ \.(generated|gen)\. ]] || grep -l "Generated by" "$file" > /dev/null 2>&1; then
echo "=== Found potentially generated file: $file ==="
# Show the last few lines to check formatting
echo "Last few lines:"
tail -n 5 "$file"
echo
# Check if file ends with exactly one newline
if [ -s "$file" ]; then
if [ -z "$(tail -c1 "$file")" ]; then
echo "File ends with a newline"
else
echo "File does not end with a newline"
fi
fi
echo "---"
fi
done
Length of output: 135012
Script:
#!/bin/bash
# Let's check for recently modified files in the repository to find actual generated files
# and examine their content, focusing on the end of files
# Find files modified in the last day, excluding node_modules and .git
find . -type f -mtime -1 -not -path "*/node_modules/*" -not -path "*/.git/*" | while read -r file; do
# Check if it's a text file
if file "$file" | grep -q "text"; then
echo "=== Examining $file ==="
# Show the last few lines and check for trailing newlines
echo "Last few lines:"
tail -n 3 "$file"
echo
# Check if file ends with exactly one newline
if [ -s "$file" ]; then
if [ -z "$(tail -c1 "$file")" ]; then
echo "File ends with a newline"
else
echo "File does not end with a newline"
fi
# Count trailing newlines
nl_count=$(tail -c2 "$file" | tr -cd '\n' | wc -c)
echo "Number of trailing newlines: $nl_count"
fi
echo "---"
fi
done
Length of output: 123137
Script:
#!/bin/bash
# Let's try a different approach to check generated files and their formatting
# using cat and wc to examine file content and newlines
# First, let's find any recently generated files
find . -type f -mtime -1 -not -path "*/node_modules/*" -not -path "*/.git/*" -exec sh -c '
for file do
if head -n1 "$file" | grep -q "Generated" || echo "$file" | grep -E "\.(generated|gen)\." > /dev/null; then
echo "=== Examining generated file: $file ==="
# Count total lines and trailing newlines
total_lines=$(wc -l < "$file")
echo "Total lines: $total_lines"
# Check trailing newlines
if [ -s "$file" ]; then
trailing_newlines=$(tail -c2 "$file" | tr -cd "\n" | wc -c)
echo "Trailing newlines: $trailing_newlines"
# Show last few lines
echo "Last few lines:"
tail -n 3 "$file"
fi
echo "---"
fi
done
' sh {} +
# Also check the specific file mentioned in the review
echo "=== Examining code-gen.ts ==="
if [ -f "./packages/sdk/src/code-gen.ts" ]; then
echo "Last few lines:"
tail -n 5 "./packages/sdk/src/code-gen.ts"
echo
if [ -s "./packages/sdk/src/code-gen.ts" ]; then
trailing_newlines=$(tail -c2 "./packages/sdk/src/code-gen.ts" | tr -cd "\n" | wc -c)
echo "Trailing newlines: $trailing_newlines"
fi
fi
Length of output: 1645
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.