Skip to content

fix(server): return an object without primary data for delete route #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/server/src/api/rest/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1103,8 +1103,8 @@ class RequestHandler extends APIHandlerBase {
where: this.makePrismaIdFilter(typeInfo.idFields, resourceId),
});
return {
status: 204,
body: undefined,
status: 200,
body: { meta: {} },
};
}

Expand Down
2 changes: 1 addition & 1 deletion packages/server/tests/adapter/express.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ describe('Express adapter tests - rest handler', () => {
expect(r.body.data.attributes.email).toBe('[email protected]');

r = await request(app).delete(makeUrl('/api/user/user1'));
expect(r.status).toBe(204);
expect(r.status).toBe(200);
expect(await prisma.user.findMany()).toHaveLength(0);
});
});
Expand Down
2 changes: 1 addition & 1 deletion packages/server/tests/adapter/fastify.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ describe('Fastify adapter tests - rest handler', () => {
expect(r.json().data.attributes.email).toBe('[email protected]');

r = await app.inject({ method: 'DELETE', url: '/api/user/user1' });
expect(r.statusCode).toBe(204);
expect(r.statusCode).toBe(200);
expect(await prisma.user.findMany()).toHaveLength(0);
});
});
2 changes: 1 addition & 1 deletion packages/server/tests/adapter/hono.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ describe('Hono adapter tests - rest handler', () => {
expect((await unmarshal(r)).data.attributes.email).toBe('[email protected]');

r = await handler(makeRequest('DELETE', makeUrl(makeUrl('/api/user/user1'))));
expect(r.status).toBe(204);
expect(r.status).toBe(200);
expect(await prisma.user.findMany()).toHaveLength(0);
});
});
Expand Down
2 changes: 1 addition & 1 deletion packages/server/tests/adapter/next.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ model M {
expect(resp.body.data.attributes.value).toBe(2);
});

await makeTestClient('/m/1', options).del('/').expect(204);
await makeTestClient('/m/1', options).del('/').expect(200);
expect(await prisma.m.count()).toBe(0);
});
});
2 changes: 1 addition & 1 deletion packages/server/tests/adapter/sveltekit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ describe('SvelteKit adapter tests - rest handler', () => {
expect((await unmarshal(r)).data.attributes.email).toBe('[email protected]');

r = await handler(makeRequest('DELETE', makeUrl(makeUrl('/api/user/user1'))));
expect(r.status).toBe(204);
expect(r.status).toBe(200);
expect(await prisma.user.findMany()).toHaveLength(0);
});
});
Expand Down
8 changes: 4 additions & 4 deletions packages/server/tests/api/rest.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2340,8 +2340,8 @@ describe('REST server tests', () => {
prisma,
});

expect(r.status).toBe(204);
expect(r.body).toBeUndefined();
expect(r.status).toBe(200);
expect(r.body).toMatchObject({ meta: {} });
});

it('deletes an item with compound id', async () => {
Expand All @@ -2355,8 +2355,8 @@ describe('REST server tests', () => {
path: `/postLike/1${idDivider}user1`,
prisma,
});
expect(r.status).toBe(204);
expect(r.body).toBeUndefined();
expect(r.status).toBe(200);
expect(r.body).toMatchObject({ meta: {} });
});

it('returns 404 if the user does not exist', async () => {
Expand Down
Loading