merge dev to main (v2.12.1)

package.json

@@ -1,6 +1,6 @@
 {
     "name": "zenstack-monorepo",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "description": "",
     "scripts": {
         "build": "pnpm -r --filter=\"!./packages/ide/*\" build",

packages/ide/jetbrains/build.gradle.kts

@@ -9,7 +9,7 @@ plugins {
 }
 
 group = "dev.zenstack"
-version = "2.12.0"
+version = "2.12.1"
 
 repositories {
     mavenCentral()

packages/ide/jetbrains/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jetbrains",
-  "version": "2.12.0",
+  "version": "2.12.1",
   "displayName": "ZenStack JetBrains IDE Plugin",
   "description": "ZenStack JetBrains IDE plugin",
   "homepage": "https://zenstack.dev",

packages/language/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@zenstackhq/language",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "displayName": "ZenStack modeling language compiler",
     "description": "ZenStack modeling language compiler",
     "homepage": "https://zenstack.dev",

packages/misc/redwood/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@zenstackhq/redwood",
     "displayName": "ZenStack RedwoodJS Integration",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "description": "CLI and runtime for integrating ZenStack with RedwoodJS projects.",
     "repository": {
         "type": "git",

packages/plugins/openapi/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@zenstackhq/openapi",
   "displayName": "ZenStack Plugin and Runtime for OpenAPI",
-  "version": "2.12.0",
+  "version": "2.12.1",
   "description": "ZenStack plugin and runtime supporting OpenAPI",
   "main": "index.js",
   "repository": {

packages/plugins/swr/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@zenstackhq/swr",
     "displayName": "ZenStack plugin for generating SWR hooks",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "description": "ZenStack plugin for generating SWR hooks",
     "main": "index.js",
     "repository": {

packages/plugins/tanstack-query/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@zenstackhq/tanstack-query",
     "displayName": "ZenStack plugin for generating tanstack-query hooks",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "description": "ZenStack plugin for generating tanstack-query hooks",
     "main": "index.js",
     "exports": {

packages/plugins/trpc/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@zenstackhq/trpc",
     "displayName": "ZenStack plugin for tRPC",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "description": "ZenStack plugin for tRPC",
     "main": "index.js",
     "repository": {

packages/runtime/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@zenstackhq/runtime",
     "displayName": "ZenStack Runtime Library",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "description": "Runtime of ZenStack for both client-side and server-side environments.",
     "repository": {
         "type": "git",

packages/runtime/src/cross/model-meta.ts

@@ -86,8 +86,7 @@ export type FieldInfo = {
     relationField?: string;
 
     /**
-     * Mapping from foreign key field names to relation field names.
-     * Only available on relation fields.
+     * Mapping from relation's pk to fk. Only available on relation fields.
      */
     foreignKeyMapping?: Record<string, string>;
 

packages/runtime/src/enhancements/node/default-auth.ts

@@ -126,31 +126,24 @@ class DefaultAuthHandler extends DefaultPrismaProxyHandler {
                 return;
             }
 
-            if (context.field?.backLink && context.nestingPath.length > 1) {
+            if (context.field?.backLink) {
                 // if the fk field is in a creation context where its implied by the parent,
                 // we should not set the default value, e.g.:
                 //
                 // ```
                 // parent.create({ data: { child: { create: {} } } })
                 // ```
                 //
-                // event if child's fk to parent has a default value, we should not set default
+                // even if child's fk to parent has a default value, we should not set default
                 // value here
 
-                // fetch parent model from the parent context
-                const parentModel = getModelInfo(
-                    this.options.modelMeta,
-                    context.nestingPath[context.nestingPath.length - 2].model
-                );
-
-                if (parentModel) {
-                    // get the opposite side of the relation for the current create context
-                    const oppositeRelationField = requireField(this.options.modelMeta, model, context.field.backLink);
-                    if (parentModel.name === oppositeRelationField.type) {
-                        // if the opposite side matches the parent model, it means we currently in a creation context
-                        // that implicitly sets this fk field
-                        return;
-                    }
+                // get the opposite side of the relation for the current create context
+                const oppositeRelationField = requireField(this.options.modelMeta, model, context.field.backLink);
+                if (
+                    oppositeRelationField.foreignKeyMapping &&
+                    Object.values(oppositeRelationField.foreignKeyMapping).includes(fieldInfo.name)
+                ) {
+                    return;
                 }
             }
 

packages/runtime/src/enhancements/node/proxy.ts

@@ -267,12 +267,7 @@ export function makeProxy<T extends PrismaProxyHandler>(
                 if ($extends && typeof $extends === 'function') {
                     return (...args: any[]) => {
                         const result = $extends.bind(target)(...args);
-                        if (!result[PRISMA_PROXY_ENHANCER]) {
-                            return makeProxy(result, modelMeta, makeHandler, name + '$ext', errorTransformer);
-                        } else {
-                            // avoid double wrapping
-                            return result;
-                        }
+                        return makeProxy(result, modelMeta, makeHandler, name + '$ext', errorTransformer);
                     };
                 } else {
                     return $extends;
@@ -289,7 +284,7 @@ export function makeProxy<T extends PrismaProxyHandler>(
                 return propVal;
             }
 
-            return createHandlerProxy(makeHandler(target, prop), propVal, prop, errorTransformer);
+            return createHandlerProxy(makeHandler(target, prop), propVal, prop, proxy, errorTransformer);
         },
     });
 
@@ -303,10 +298,15 @@ function createHandlerProxy<T extends PrismaProxyHandler>(
     handler: T,
     origTarget: any,
     model: string,
+    dbOrTx: any,
     errorTransformer?: ErrorTransformer
 ): T {
     return new Proxy(handler, {
         get(target, propKey) {
+            if (propKey === '$parent') {
+                return dbOrTx;
+            }
+
             const prop = target[propKey as keyof T];
             if (typeof prop !== 'function') {
                 // the proxy handler doesn't have this method, fall back to the original target

packages/schema/package.json

@@ -3,7 +3,7 @@
     "publisher": "zenstack",
     "displayName": "ZenStack Language Tools",
     "description": "FullStack enhancement for Prisma ORM: seamless integration from database to UI",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "author": {
         "name": "ZenStack Team"
     },

packages/sdk/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@zenstackhq/sdk",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "description": "ZenStack plugin development SDK",
     "main": "index.js",
     "scripts": {

packages/server/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@zenstackhq/server",
-    "version": "2.12.0",
+    "version": "2.12.1",
     "displayName": "ZenStack Server-side Adapters",
     "description": "ZenStack server-side adapters",
     "homepage": "https://zenstack.dev",

packages/testtools/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zenstackhq/testtools",
-  "version": "2.12.0",
+  "version": "2.12.1",
   "description": "ZenStack Test Tools",
   "main": "index.js",
   "private": true,

tests/integration/tests/enhancements/proxy/extension-context.test.ts

@@ -0,0 +1,78 @@
+import { loadSchema } from '@zenstackhq/testtools';
+
+describe('Proxy Extension Context', () => {
+    it('works', async () => {
+        const { enhance } = await loadSchema(
+            `
+            model Counter {
+                model String @unique
+                value Int
+
+                @@allow('all', true)
+            }
+
+            model Address {
+                id   String @id @default(cuid())
+                city String
+
+                @@allow('all', true)
+            }
+            `
+        );
+
+        const db = enhance();
+        const dbExtended = db.$extends({
+            client: {
+                $one() {
+                    return 1;
+                }
+            },
+            model: {
+                $allModels: {
+                    async createWithCounter(this: any, args: any) {
+                        const modelName = this.$name;
+                        const dbOrTx = this.$parent;
+
+                        // prisma exposes some internal properties, makes sure these are still preserved
+                        expect(dbOrTx._engine).toBeDefined();
+
+                        const fn = async (tx: any) => {
+                            const counter = await tx.counter.findUnique({
+                                where: { model: modelName },
+                            });
+
+                            await tx.counter.upsert({
+                                where: { model: modelName },
+                                update: { value: (counter?.value ?? 0) + tx.$one() },
+                                create: { model: modelName, value: tx.$one() },
+                            });
+
+                            return tx[modelName].create(args);
+                        };
+
+                        if (dbOrTx['$transaction']) {
+                            // not running in a transaction, so we need to create a new transaction
+                            return dbOrTx.$transaction(fn);
+                        }
+
+                        return fn(dbOrTx);
+                    },
+                },
+            },
+        });
+
+        const cities = ['Vienna', 'New York', 'Delhi'];
+
+        await Promise.all([
+            ...cities.map((city) => dbExtended.address.createWithCounter({ data: { city } })),
+            ...cities.map((city) =>
+                dbExtended.$transaction((tx: any) => tx.address.createWithCounter({ data: { city: `${city}$tx` } }))
+            ),
+        ]);
+
+        await expect(dbExtended.counter.findUniqueOrThrow({ where: { model: 'Address' } })).resolves.toMatchObject({
+            model: 'Address',
+            value: cities.length * 2,
+        });
+    });
+});

tests/regression/tests/issue-2014.test.ts

@@ -0,0 +1,39 @@
+import { loadSchema } from '@zenstackhq/testtools';
+
+describe('issue 2014', () => {
+    it('regression', async () => {
+        const { prisma, enhance } = await loadSchema(
+            `
+            model Tenant {
+              id    Int    @id @default(autoincrement())
+
+              users User[]
+            }
+
+            model User {
+              id       Int    @id @default(autoincrement())
+              tenantId Int    @default(auth().tenantId)
+              tenant   Tenant @relation(fields: [tenantId], references: [id])
+
+              @@allow('all', true)
+            }
+            `,
+            { logPrismaQuery: true }
+        );
+
+        const tenant = await prisma.tenant.create({ data: {} });
+        const user = await prisma.user.create({ data: { tenantId: tenant.id } });
+
+        const db = enhance(user);
+        const extendedDb = db.$extends({});
+
+        await expect(
+            extendedDb.user.create({
+                data: {},
+            })
+        ).resolves.toEqual({
+            id: 2,
+            tenantId: tenant.id,
+        });
+    });
+});