Fix false positive on jsonMatches #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm all good for that fix 👍 but why did you change the workflow? |
|
Tried to fix the issues mentioned in #178 with nearest commit from 1/12/2022 (latest change on the line). As it's not working, I will revert that. :-) |
nikophil
reviewed
Aug 26, 2025
|
I'm merging this PR, but I'd really like that we fix the CI before any further release |
nikophil
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #127
As far as I understood it, it's due to
Assert::iswhich is the same asassertSameof phpunit.I switched to
Assert::equalswhich is the same asassertEqualsof phpunit.The error will now be throw only if two array:list are compared.
As it's not an issue for a json object to have a different index order, this fix is fine to me. Let me know if there is another option you have in mind.
The message comes from
zenstruck/assertlibrary but I don't think we can improve that...