dts: -pinctrl.dtsi: Label clean up and HSPI signals #279
Conversation
erwango
commented
May 7, 2025
erwango
commented
- Rename ETH N6 IP label to be less confusing when generated on other series.
- Generate ETH extended signals on STM32MP13
- Generate HSPI signals (STM32U5)
Use "ETH Extended" as a less confusing name. Signed-off-by: Erwan Gouriou <[email protected]>
There was a problem hiding this comment.
For commit "dts: New batch with new ETH label and MP13 signals":
Would be nice to be plit in 2 commits: one for the ETH label and one for adding MP13 pinctrl nodes.
For commit "dts: New batch with HSPI signals":
There are more than only HSPI related changes in this commit. Could you move the JTAG port related changes into a specific commit?
|
Thanks, fixed. |
| @@ -247,4 +247,3 @@ | |||
|
|
|||
| - name: USB | |||
| match: "^USB_(?:DM)?(?:DP)?(?:NOE)?$" | |||
|
|
|||
There was a problem hiding this comment.
Nitpicking: I think you should discard the change on this last file line.
There was a problem hiding this comment.
It should not have been added and was removed by my editor. I'll keep it that way.
There was a problem hiding this comment.
Comment for commits "dts: New batch with new ETH label" and "dts: ETH MP13 signals":
The 2 commit messages only mention ETH but also add data related to SAI and a few UART related devices. I would propose you squash the 2 commits and update the commit messages to mention also updates of SAI and UART related devices.
Generate a new batch with Eth modified label (N6 and MP1) Signed-off-by: Erwan Gouriou <[email protected]>
MP13: Eth (extended) signals addition MP13: SAI signals addition MP13: Update drive/bias prop on USART signals The fact that these MP13 signals/updates were missing is a consequence of a race between MP13 introductions and previous PRs. They should have already been available. Signed-off-by: Erwan Gouriou <[email protected]>
Add a filter for HSPI signals available on U5 series. Signed-off-by: Erwan Gouriou <[email protected]>
Generate a new batch with HSPI signals Signed-off-by: Erwan Gouriou <[email protected]>
