Skip to content

stm32cube: stm32h5: rcc: remove extraneous parentheses #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stm32cube: stm32h5: rcc: remove extraneous parentheses #316

wants to merge 1 commit into from

Conversation

tpambor
Copy link

@tpambor tpambor commented Oct 7, 2025

Fix warning about extraneous parentheses when compiling with clang.

/home/user/west_workspace/modules/hal/stm32/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_rcc_ex.c:3513:26: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
 3513 |         else if ((srcclk == RCC_USART2CLKSOURCE_PLL3Q))
      |                   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/user/west_workspace/modules/hal/stm32/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_rcc_ex.c:3513:26: note: remove extraneous parentheses around the comparison to silence this warning
 3513 |         else if ((srcclk == RCC_USART2CLKSOURCE_PLL3Q))
      |                  ~       ^                           ~
/home/user/west_workspace/modules/hal/stm32/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_rcc_ex.c:3513:26: note: use '=' to turn this equality comparison into an assignment
 3513 |         else if ((srcclk == RCC_USART2CLKSOURCE_PLL3Q))
      |                          ^~
      |                          =

Related STM32CubeH5 HAL issue: STMicroelectronics/stm32h5xx-hal-driver#14
Related STM32CubeH5 HAL PR: STMicroelectronics/stm32h5xx-hal-driver#15

@tpambor tpambor force-pushed the fix-extraneous-parentheses branch from 2519290 to 2829f35 Compare October 7, 2025 19:26
@tpambor
stm32cube: stm32h5: rcc: remove extraneous parentheses
331ae51 
Fix warning about extraneous parentheses when compiling with clang.

Signed-off-by: Tim Pambor <[email protected]>
@tpambor tpambor force-pushed the fix-extraneous-parentheses branch from 2829f35 to 331ae51 Compare October 7, 2025 19:27
@github-actions github-actions bot mentioned this pull request Oct 9, 2025
Open
@erwango erwango self-requested a review October 10, 2025 11:11
erwango
erwango approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@erwango erwango left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the README update with the required information. Perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tpambor @erwango