drivers: video: fix uninitialized struct in ov2640_init() #92151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
avolmat-st,
josuah,
loicpoulain and
ngphibang
josuah
approved these changes
Jun 25, 2025
avolmat-st
reviewed
Jun 25, 2025
There was a problem hiding this comment.
Code LGTM.
Maybe just clarify a bit the commit log ? I missed that in the recent patch merged which does similar change on other drivers. This is no more Zero-initiialize since now video_format is initialized to the default format (only pitch variable is 0 initialized).
Would it be possible to just change this line of the commit log ?
|
CI fails for now but seems infrastructure-related, not specific to this PR. |
Initialize fmt with default format and zero pitch to fix Coverity. CID: 524780 Signed-off-by: Gaetan Perrot <[email protected]>
moonlight83340
force-pushed
the
Coverity_CID_524780
branch
from
822a1c2 to
c696ef0
Compare
|
Does the new commit log make more sense ? |
|
avolmat-st
approved these changes
Jun 26, 2025
ngphibang
approved these changes
Jun 26, 2025
josuah
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero-initialize fmt to fix Coverity.
CID: 524780
Fix #90472