drivers: ethernet: dont require mac address in dts #92166
+44
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure, that zephyr,random-mac-address has a higher prio, than local-mac-address, as documented in ethernet-controller.yaml. Also make sure, that no vaild mac address doesn't lead to init fail, as it can still be set later via set_config. Signed-off-by: Fin Maaß <[email protected]>
only set a random mac if zephyr,random-mac-address is set in dt. Signed-off-by: Fin Maaß <[email protected]>
make sure, that zephyr,random-mac-address has a higher prio, than local-mac-address, as documented in ethernet-controller.yaml. Signed-off-by: Fin Maaß <[email protected]>
use DT_INST_PROP_OR for local-mac-address, so that it is not required to be set in dt, as there are other ways to se the mac address. Signed-off-by: Fin Maaß <[email protected]>
|
github-actions
bot
added
platform: LiteX
platform: Infineon
github-actions
bot
requested review from
clamattia,
dbaluta,
decsny,
dleach02,
fkokosinski,
henrikbrixandersen,
ibirnbaum,
kgugala,
lmajewski,
manuargue,
michalsimek,
mmahadevan108,
pdgendt,
Raymond0225 and
tgorochowik
decsny
approved these changes
Jun 25, 2025
|
drivers/ethernet/eth_xilinx_axienet.c: Changes look fine to me. |
pdgendt
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local-mac-addressto be present in the dtzephyr,random-mac-addresswas only used iflocal-mac-addresswas not valid.zephyr,random-mac-addresshas priority overlocal-mac-addressaccording toethernet-controller.yaml.