boards: arm: add probe-rs runner for RP2350 boards #94542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soburi
previously approved these changes
Aug 15, 2025
kartben
previously approved these changes
Aug 15, 2025
ajf58
requested changes
Aug 18, 2025
dsseng
commented
Aug 19, 2025
| @@ -16,3 +18,4 @@ board_runner_args(uf2 "--board-id=RP2350") | |||
|
|
|||
| include(${ZEPHYR_BASE}/boards/common/uf2.board.cmake) | |||
| include(${ZEPHYR_BASE}/boards/common/openocd.board.cmake) | |||
| include(${ZEPHYR_BASE}/boards/common/probe-rs.board.cmake) | |||
There was a problem hiding this comment.
Sorting this would involve out of scope changes. Avoided for this reason as generally maintainers are opposed of format changes in functional change PRs
There was a problem hiding this comment.
That's fair. FWIW I'm happy with PRs that have a series of commits that are "sorting ahead of adding more things", then "add the new thing" in the net commit. Yes, combining these in one commit would be bad.
There was a problem hiding this comment.
Should I do this here?
There was a problem hiding this comment.
No, I think it's ok as-is, and would be added scope creep.
dsseng
force-pushed
the
rp2350-probe-rs
branch
from
8ac3096 to
557a2ee
Compare
Add the chip parameter for probe-rs. Verified on Feather RP2350. Signed-off-by: Dmitrii Sharshakov <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
soburi
approved these changes
Aug 19, 2025
ajf58
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the chip parameter for probe-rs. Verified on Feather RP2350.
Signed-off-by: Dmitrii Sharshakov [email protected]