drivers: sensor: npm13xx_charger: improve sample fetching #94546
+45
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
aasinclair,
anangl,
avisconti,
jaz1-nordic,
jeppenodgaard,
kl-cruz,
magp-nordic,
masz-nordic,
MaureenHelm,
nika-nordic,
teburd,
tristan-google,
ubieda and
yperess
nordic-auko
reviewed
Aug 20, 2025
Change the npm13xx_charger fetch function to first trigger a sample and then block until the result is available. Signed-off-by: Sergei Ovchinnikov <[email protected]>
seov-nordic
force-pushed
the
npm13xx-charger-improve-measurement-fetching
branch
from
72ae685 to
7ea2956
Compare
|
nordic-auko
approved these changes
Aug 25, 2025
|
|
||
| return i2c_write_dt(&config->i2c, buff, sizeof(buff)); | ||
| return i2c_transfer_dt(&config->i2c, msg, 2); |
There was a problem hiding this comment.
Nitpick:
Suggested change
| return i2c_transfer_dt(&config->i2c, msg, 2); | |
| return i2c_transfer_dt(&config->i2c, msg, ARRAY_SIZE(msg)); |
|
@anangl or @masz-nordic, could you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the npm13xx_charger fetch function to first trigger a sample and then block until the result is available.