You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this should be guarded behind a kconfig as this changes existing behavior.
@dcpleung it is already behind a Kconfig, so you think that CONFIG_GDBSTUB isn't enough - just enabling the GDB stub shouldn't yet mean, that we want to start it if an exception occurs and we need a finer grained control over this, i.e. an additional Kconfig? Can be done, sure
I think it is a good idea that this behavior has to be turned on explicitly and does not only rely on GDB stub being enabled. An app can override the default exception handling and can recover from it (like in some tests). If this code jumps directly to GDB stub, it will look like it's spinning forever to the developer and the exception not being handled. That's why I think it is a good idea to guard it with kconfig, so that the current behavior is preserved.
If the GDB stub is enabled the exception handler will jump to the GDB
stub to allow remote GDB debugging.
Signed-off-by: Guennadi Liakhovetski <[email protected]>
I think it is a good idea that this behavior has to be turned on explicitly and does not only rely on GDB stub being enabled. An app can override the default exception handling and can recover from it (like in some tests). If this code jumps directly to GDB stub, it will look like it's spinning forever to the developer and the exception not being handled. That's why I think it is a good idea to guard it with kconfig, so that the current behavior is preserved.
@dcpleung ok, you mean a dedicated Kconfig. No problem, added
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the GDB stub is enabled the exception handler will jump to the GDB stub to allow remote GDB debugging.