drivers: stepper: refactor stepper_handle_timing_signal in step_dir_common & redefine behavior of move_by(dev, 0) #94555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilaypandya
force-pushed
the
refactor/step-dir-common-set-direction
branch
2 times, most recently
from
7368c42 to
aaa21ba
Compare
jilaypandya
changed the title
jilaypandya
changed the title
jilaypandya
force-pushed
the
refactor/step-dir-common-set-direction
branch
3 times, most recently
from
d69fbe8 to
8521709
Compare
move_by(dev,0) shall stop the timing source and trigger STEPPER_EVENT_STEPS_COMPLETED event Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
refactor/step-dir-common-set-direction
branch
from
8521709 to
ed1d447
Compare
zephyrbot
requested review from
bjarki-andreasen,
dipakgmx,
fabiobaltieri,
faxe1008 and
jbehrensnx
faxe1008
reviewed
Aug 16, 2025
jilaypandya
force-pushed
the
refactor/step-dir-common-set-direction
branch
from
ed1d447 to
b0003ef
Compare
jilaypandya
force-pushed
the
refactor/step-dir-common-set-direction
branch
from
b0003ef to
26d7cad
Compare
dipakgmx
reviewed
Aug 18, 2025
1. Reduce the spinlock scope in stepper_handle_timing_signal 2. perform a step each time the timing signal is called 3. Increment/Decrement actual_position and steps using atomics Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
refactor/step-dir-common-set-direction
branch
from
26d7cad to
83d5250
Compare
|
dipakgmx
approved these changes
Aug 18, 2025
fabiobaltieri
approved these changes
Aug 18, 2025
faxe1008
approved these changes
Aug 18, 2025
bjarki-andreasen
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.