use variable already set for URL and remove whitespace.

[DanielOchoa]

It seems this is the most popular way to set up meteor apps in phonegap. Have you considered making this a npm package so it can be set up with one command on a cordova project?

[zeroasterisk]

Whoa!

I guess it's time to put on my big-boy-pants and take this seriously vs. the experiment it started out as, eh?

Thanks for the PR and the rewrite...

Give me a few days to dust things off and try this out myself on a couple of platforms, but reading through it, I suspect it will work fine.

Out of curiosity what platforms have you tested this on so far?

Also you mentioned making it a npm package... I'm on board with that plan, but unsure how to tell NPM to install the JS to the shared www/js folder in cordova. recommendations?

[DanielOchoa]

No problem, it's always nice to contribute. I've noticed a few blogs and apps mention that they are using this method and it seems that it works really well and that integrates with Cordova plugins without too many issues.

As you can see I'm also phasing out zepto so as to not have all that code included when meteor loads. As far as testing goes I'm only testing it on iOS for now, but I'm sure it will work fine on Android.

For the NPM idea, I already set up this repo: https://github.com/poetic/meteor-rider. It uses a node script to copy the files into the Cordova project - it also asks you for the meteor url and replaces it on the new index.html file. Since you are open to the npm idea, It's probably better to move the npm package to use your repo instead.

[DanielOchoa]

It is not, good catch. I'm still working on cleaning it up. I agree that it being a property set on init is better just like I originally had it, then I realized the meteorUrl property was returning undefined inside the onSuccess function.

I just set it up that way so it works for now while I fix it. Perhaps I should have not committed it that way.

[zeroasterisk]

no problem... at least we are on the same page...

Could it be that when you set the onSuccess function you are passing in just the function, not the object.function?

In which case this refers to the request object, not MeteorRider...

[DanielOchoa]

Actually, yes, that is the case.
this.onSuccess.bind(this); now allows us to reference MeteorRider when using this inside onSuccess.

[zeroasterisk]

@DanyHunter would you do me a solid and try out the latest release on the [dev] branch?

https://github.com/zeroasterisk/MeteorRider/tree/dev

also review the updated README -- yes, i know the image is missing because it's pathed to master :/

[DanielOchoa]

For sure.