Improve namespace generation in PHP #4270
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves namespace generation in PHP by consolidating namespace declarations to avoid unnecessary reopening. Instead of wrapping each PHP construct in its own namespace declaration, the code now uses a module-based approach with proper namespace stacking to handle nested modules while respecting PHP's lack of support for truly nested namespaces.
- Replaces per-construct namespace wrapping with module-level namespace management
- Implements namespace stack to handle module nesting by closing/reopening namespaces as needed
- Removes redundant
startNamespace/endNamespacecalls from individual construct visitors
| { | ||
| _out << eb; | ||
| _parentNamespaces.pop(); | ||
| if (!_parentNamespaces.empty()) |
There was a problem hiding this comment.
The stack could become empty during visitModuleEnd, but there's no check to prevent popping from an empty stack. This could cause undefined behavior if modules are not properly balanced.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
My assumption is the Parser guarantees proper balancing of start/end.
There was a problem hiding this comment.
Yes, this is guaranteed.
Co-authored-by: Copilot <[email protected]>
PHP does not support nesting a namespace with a namespace, but it supports sub-namespaces.
Prior to this PR, we were simply opening the namespace around each mapped PHP construct ... lots of namespaces. This PR reduces the number of PHP namespace reopening.