[GH-25] Fix persistent split/merged flags causing data corruption #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bool-typed fields `merged` and `split` in the ProllyNode struct were being persisted through serialization and never reset to false, causing severe data corruption during tree operations. This commit fixes the issue by: 1. Making split/merged flags transient using #[serde(skip)] 2. Ensuring flags are always reset to false when nodes are retrieved from storage 3. Adding comprehensive tests to verify the fix and prevent regressions The fix prevents catastrophic data corruption where: - Split nodes would have their edges incorrectly hoisted to parent on every operation - Merged nodes would have their siblings incorrectly dropped from parent 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
zhangfengcdt
changed the title
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical bug where the
splitandmergedboolean flags inProllyNodewere being persisted and never reset, causing severe data corruption during tree operations.Problem
The
splitandmergedflags were:falseafter operations completedSolution
#[serde(skip)]to prevent serializationfalsewhen nodes are loadedChanges
#[serde(skip)]to split/merged fields, added verification testsInMemoryNodeStorageandFileNodeStorageto reset flags on retrievalTesting
Impact
This fix prevents data corruption and ensures tree integrity across all operations involving node splits and merges.
🤖 Generated with Claude Code