Windows (MSVC) bootstrapping script #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcbanner
force-pushed
the
msvc_build
branch
2 times, most recently
from
b0d1d36 to
0dcf1bc
Compare
add failure checks fixup paths
…use the alternate compiler with the visual studio generator fix variable quoting
…lify by using it for all cmake builds
- Disabled building targets with msvc ABI - Added build options for supporting the msvc ABI, once support lands in the linker
- Build zlib with the same cflags as zig, so the runtimes are compatible when built with msvc - Remove -Denable-stage1
|
Moving into review now that ziglang/zig#14002 and ziglang/zig#13514 are in review. |
|
I see that the patch has landed upstream in the main branch in llvm/llvm-project@dfbaf90, so it's OK for us to carry that patch until we update to LLVM 16 👍 |
…at ZIG_ENABLE_ZSTD was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using build.bat, you can start with MSVC (and the msvc bundled cmake/ninja), and end up with an x64_86-windows-gnu zig.
I've pulled in this change: https://reviews.llvm.org/D134165 in order to fix up how the .def files are passed. The branch we need here is the
elseif(MINGW)one.This build script depends on changes in these pull requests: ziglang/zig#13514 ziglang/zig#14002