Skip to content

remove std.log usage from std.Build.Cache in favor of proper error reporting #14950

Open
@andrewrk

Description

@andrewrk

Extracted from #14647.

log.err("failed parsing {s}: {s}", .{ dep_file_basename, error_buf.items });

log.err("failed parsing {s}: {s}", .{ dep_file_basename, error_buf.items });

The cache system is used by the build runner during build graph execution which is multi-threaded. Errors should be properly collected into their designated places, rather than written globally to a log function. Likewise, the compiler code that uses the Cache wants to store compilation errors in the appropriate place rather than, again, being written globally to a log function.

Metadata

Metadata

Assignees

No one assigned

    Labels

    contributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.standard libraryThis issue involves writing Zig code for the standard library.zig build systemstd.Build, the build runner, `zig build` subcommand, package management

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions