Skip to content

resinator: Include directories regression in build system integration #19605

@squeek502

Description

@squeek502

Zig Version

0.12.0-dev.3594+355cceebc

Steps to Reproduce and Observed Behavior

Before #19174, the resinator preprocessor was clang and was invoked after calling addCCArgs which added mod.cc_argv and comp.global_cc_argv to the preprocessor argv. This meant that include directories added via things like std.Build.Compile.addIncludePath would make it into the argv of the preprocessor.

After #19174, that is no longer the case. Because of this, there's no real way to use a LazyPath for include directories that get passed to resinator (there's only RcSourceFile.flags which is a []const []const u8).

Expected Behavior

Either:

  • There should be a dedicated way to interface with resinator include dirs, etc through the build system (i.e. addRcIncludePath), or
  • The include dirs added via std.Build.Compile.addIncludePath, etc should be inherited by resinator (as was done with clang before)

I'm currently leaning towards the second option, but am not totally sure yet.

Metadata

Metadata

Assignees

Labels

bugObserved behavior contradicts documented or intended behaviorregressionIt worked in a previous version of Zig, but stopped working.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions